Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*based on PR #510 'Finished KPI Tests'* Finishes first round of testing #517

Merged
merged 469 commits into from
Jul 7, 2023
Merged

*based on PR #510 'Finished KPI Tests'* Finishes first round of testing #517

merged 469 commits into from
Jul 7, 2023

Conversation

anchit-chandran
Copy link
Collaborator

Additional test areas from previous PR include the following points, alongside refactors where tests were implemented to ensure regressions are prevented.

1 Permissions testing

  • For each user role, specified by the E12 team, we assert they can / can't access various url endpoints, receiving the appropriate status code

2 KPI Aggregation

  • For the main 'Organisation' page which shows summary statistics for KPIs across the E12 audit, we have implemented tests to assert the aggregations output the expected numbers, using seeded Cases with known KPI pass/fail/ineligible outcomes. Particuarly for the entire KPI aggregation function, we use 100 Cases, with all tests passing.

3 Form calculation

  • We have implemented tests to ensure, on a model basis, that both numerator and denominators denoting audit progress output the correct values, given known inputs. This includes cases where certain answers cause different numbers of options to be available, such as with new Episodes

anchit-chandran and others added 30 commits June 28, 2023 15:23
@anchit-chandran
adds 6_8_10 kpi ansawers to aggregate_kpi score test
0edfd82 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
initial draft, finished test_aggregate_all_eligible_kpi_fields_correc…
fd34933 
…t_kpi_scoring + passing; requires refactoring to be cleaner

Signed-off-by: Anchit <[email protected]>
@anchit-chandran
refactors test aggregate kpi score
b109e98 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
refactors test case uknown postcode
ffbfe44 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
rms unnecessary CaseFactory constructors in test_update_actions
6ef00d2 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds avg to test_aggregate_all_eligible_kpi_fields_correct_kpi_scoring
4321abe 
Signed-off-by: Anchit <[email protected]>
@eatyourpeas
selects start
c10b461
@anchit-chandran
docstrings for testing recalculate_form_ fn
b04442e 
Signed-off-by: Anchit <[email protected]>
@eatyourpeas
add test form calculations
9c4d28e
@anchit-chandran
Merge branch 'perms-tests' of https://github.com/rcpch/rcpch-audit-en…
de7f53f 
…gine into perms-tests
@anchit-chandran
adds test_form_calc initial docstrings
7246609 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds first completed_fields test for registration
a9c2c2a 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds tests completed_fields(first_paediatric_assessment)
600e6f5 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds completed_fields(epliepsycontext) tests
25e0db4 
Signed-off-by: Anchit <[email protected]>
@eatyourpeas
completed test update
3a700f9
@eatyourpeas
investigations/management docstrings form test
c5ff1fe
@anchit-chandran
Merge branch 'perms-tests' of https://github.com/rcpch/rcpch-audit-en…
337373f 
…gine into perms-tests

Signed-off-by: Anchit <[email protected]>
@anchit-chandran
fixes test seeding errors
dfafdb9 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
skips failing test in test_update_actions
4a0a7c8 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds assessment form calc tests
b2035bc 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds investigations completed fields tests
b5c856b 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
fix E12Managementfactory setting has_an_aed_been_given=True when sodi…
fe9d5c6 
…um_valproate=None set in E12CaseFactory constructor

Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds management completefields test ALL fields
9eea501 
Signed-off-by: Anchit <[email protected]>
@eatyourpeas
multiaxial diagnosis docstrings
57ae860
@eatyourpeas
dbaction comorbidity
c2ebaa5
@eatyourpeas
update docstrings
606df3a
@eatyourpeas
fix select list
dbd22fc
@eatyourpeas
complete selects
c0fd1e7
@eatyourpeas
add select fails db action tests
e89d0d0
@anchit-chandran
Merge branch 'perms-tests' of https://github.com/rcpch/rcpch-audit-en…
bd5b816 
…gine into perms-tests

Signed-off-by: Anchit <[email protected]>
anchit-chandran and others added 27 commits July 7, 2023 16:11
@anchit-chandran
rms unused imports multiax factory
65f019f 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds RANDOM completed_fields(model_instance=multiaxial_diagnosis)
9dc9e81 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
rm default syndrome from SyndromeFactory
d577ba3 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
updates docstrings finished test_completed_fields
5e69a5f 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds syndrome==None case for str repr of Syndrome model
133fae5 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
change str repr empty syndrome
a2b2455 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
adds episode tests for count completed fields related model
dfacdf7 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
formats test_number completed fields file
8d8cccd
@anchit-chandran
test gpg cred
cf4fe1b 
Signed-off-by: Anchit <[email protected]>
@anchit-chandran
rm commented code e12aemfactory
95fbef3 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds count related model fields tests for Syndrome
b1dff9b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds completed fields related model count for Comorbidity
740553e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_related_model_fields_count_management
6e2551e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_related_model_fields_count_registration, finishes tests for…
6de70da 
… this form calc fn

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_correct_output_scoreable_fields_for_model_class_name, add…
83ac32d 
…s expected_field constant dataclass

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
refactors scoreable_fields_for_model_class_name to use dataclass co…
8de00fa 
…nstant

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds initial test_count_episode_fields and `test_total_fields_expec…
6d9df7b 
…ted_multiaxial_diagnosis_episode_fields`

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_total_fields_expected_multiaxial_diagnosis_syndrome_fields
2781b5d 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
Adds test_total_fields_expected_multiaxial_diagnosis_general_fields a…
0c879e4 
…nd for assessment

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
Adds test_total_fields_expected_investigations and registration
610ba64 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_total_fields_expected_management
2d14e2f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds tests for expected_score_for_single_episode for all non-epilepti…
f15aac3 
…c / uncertain episodes

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
avoid_fields adds META_VARIABLES constant for lookup
34dd68b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
better contrast colors for kpi agg bar charts
6a8e5d6 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
eeg tooltip text update as per issue Add NICE guidance re investigati…
7a5d2b5 
…on requesting post-diagnosis into tooltip #468

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
updates test_measure_2 docstrings - more accurately describes test
15f3542 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
Merge branch 'perms-tests' of https://github.com/rcpch/rcpch-audit-en…
3046ece 
…gine into perms-tests
pacharanero
pacharanero approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@pacharanero pacharanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally & all passing

@pacharanero pacharanero merged commit c59f5e3 into development Jul 7, 2023
@pacharanero pacharanero deleted the perms-tests branch July 7, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacharanero pacharanero pacharanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchit-chandran @pacharanero @eatyourpeas